Generally, to get attention for a patch, you have to find three reviewers to assert
that the patch applies cleanly, passes the automated tests, and ???works??? for them.
They do this by making an appropriate comment (as simple as ???+1 for me???) in
the ticket??™s comments. Once you have three reviewers, it is up to you to add the
verified keyword to the ticket to indicate that review is complete.
Be available
At this point, your ticket will show up in the ???verified??? report (http://dev.
rubyonrails.org/report/12). Patches in this queue are usually acted upon quickly,
whether the action is acceptance, rejection, or sending it back for more discussion.
Contributing to Rails | 293
Rails contributors use ticket status and resolutions as a way to deal with the
large volume of incoming tickets. It is common for a ticket to be opened and
closed a few times before being accepted or rejected. Don??™t worry if your ticket is
closed as untested; that just means it needs tests (or, alternatively, a very good
reason why it can??™t or shouldn??™t be tested). Then it can be sent back.
Also, don??™t be discouraged if your patch is ultimately rejected. There are many features
that used to be in core Rails that have been removed or turned into plugins in
Rails 2.0. The Rails core team is focusing on keeping Rails smaller and more
agile; most frameworks tend to accumulate features without limit unless their
growth is kept in check.
Pages:
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445